verify upgrade targets separately for each group (masters, nodes, etcd) #4321
Conversation
|
aos-ci-test |
ingvagabund
force-pushed
the
verify-targets-separatelly
branch
from
5374537
to
b54a329
Compare
|
aos-ci-test |
| shell: "rpm -q --queryformat '---\ncurr_version: %{VERSION}\navail_version: \n' docker" | ||
| register: g_atomic_docker_version_result | ||
| when: openshift.common.is_atomic | bool | ||
| - name: Determine available Docker |
There was a problem hiding this comment.
Reminder: This will fail on container-engine instances in the future. However, the same method used to gain docker version on atomic will work.
There was a problem hiding this comment.
I have not modified the file, just removed the play part and kept all tasks. I can polish the task files if needed. However, we should fix this as a part of another PR, e.g. "towards atomic compatibility".
There was a problem hiding this comment.
Anyway, I would rather replace the shell with repoquery module and extend the module to be runnable on atomic as well.
|
|
||
| - name: Verify containers are available for upgrade | ||
| - when: not openshift.common.is_containerized | bool |
There was a problem hiding this comment.
Not sure, but I don't think this would work on atomic either.
|
[merge][severity: blocker] |
|
Evaluated for openshift ansible merge up to b54a329 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/498/) (Base Commit: 47a269e) (Extended Tests: blocker) |
So we don't check docker and rpm version on nodes if we upgrade the control plane only.