Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if a node_upgrade.yml playbook is run over a master host #4393

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jun 8, 2017

Node part of a master node is upgraded as part of the control plane upgrade.

Bugs: bz#1455857

@ingvagabund ingvagabund force-pushed the fail-if-node-upgrade-run-over-master branch 3 times, most recently from aaf1afe to a57b53b Compare June 8, 2017 15:28
@ingvagabund
Copy link
Member Author

aos-ci-test

@ashcrow
Copy link
Member

ashcrow commented Jun 8, 2017

@ingvagabund one thing to note, I think we still prefer assert over fail.

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for a57b53b (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for a57b53b (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for a57b53b (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for a57b53b (logs)

@ingvagabund
Copy link
Member Author

ingvagabund commented Jun 9, 2017

@ingvagabund one thing to note, I think we still prefer assert over fail.

True. Still getting used to it.

@ingvagabund
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to a57b53b

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/merge Running (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/534/) (Base Commit: e651d65)

Node part of a master node is upgraded as part of the control plane upgrade.
@ingvagabund ingvagabund force-pushed the fail-if-node-upgrade-run-over-master branch from a57b53b to 64d4ffc Compare June 9, 2017 09:20
@ingvagabund ingvagabund closed this Jun 9, 2017
@ingvagabund
Copy link
Member Author

Closed in favor of #4399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants