Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to set the serviceAccountConfig.limitSecretReferences setting in master-config.yaml #4516

Merged
merged 2 commits into from Jun 22, 2017
Merged

Adding ability to set the serviceAccountConfig.limitSecretReferences setting in master-config.yaml #4516

merged 2 commits into from Jun 22, 2017

Conversation

kwoodson
Copy link
Contributor

No description provided.

@kwoodson kwoodson self-assigned this Jun 20, 2017
@kwoodson
Copy link
Contributor Author

@sdodson @mtnbikenc, I tested this against 3.6 and this worked.

This is in regards to the bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1442332

mtnbikenc
mtnbikenc requested changes Jun 21, 2017
View reviewed changes
roles/openshift_master/README.md Outdated
| openshift_master_console_url | UNDEF | |
| openshift_master_public_api_url | UNDEF | |
| openshift_master_public_console_url | UNDEF | |
| openshift_master_saconfig_limitsecretrefereces | UNDEF | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, missing 'n', openshift_master_saconfig_limitsecretreferences
Also, it seems to me that this should reference the default value as being false, since that is what happens in the code. Possibly also add the description that is in the inventory example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtnbikenc, Thanks, let me fix.

@mtnbikenc
Copy link
Member

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for c140a54 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for c140a54 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for c140a54 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for c140a54 (logs)

@sdodson
Copy link
Member

sdodson commented Jun 21, 2017

[merge][severity:blocker]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to c140a54

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to c140a54

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/258/) (Base Commit: de93b27) (PR Branch Commit: c140a54)

@openshift-bot
Copy link

openshift-bot commented Jun 22, 2017 •
edited

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/621/) (Base Commit: 7db01fe) (PR Branch Commit: c140a54) (Extended Tests: blocker)

@openshift-bot openshift-bot merged commit d1e87ce into openshift:master Jun 22, 2017
@kwoodson kwoodson deleted the limit_refs branch September 18, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@kwoodson kwoodson

Labels
affects_3.4 affects_3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwoodson @mtnbikenc @openshift-bot @sdodson