Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Correct version comparisons to ensure proper evaluation #4647

Merged

Conversation

mtnbikenc
Copy link
Member

When a user supplies the openshift_image_tag inventory fact as '3.5',
the evaluation of version >= LooseVersion('3.5.0') will return False.
Changing the evaluation against only the X.X release will properly
return True.

Backports #4645
Bug 1443416

When a user supplies the openshift_image_tag inventory fact as '3.5',
the evaluation of `version >= LooseVersion('3.5.0')` will return False.
Changing the evaluation against only the X.X release will properly
return True.
@mtnbikenc
Copy link
Member Author

aos-ci-test

@mtnbikenc
Copy link
Member Author

[test]

Copy link
Member

@abutcher abutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 17b5de0

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 17b5de0 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 17b5de0 (logs)

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/301/) (Base Commit: 5b6f45e) (PR Branch Commit: 17b5de0)

@mtnbikenc
Copy link
Member Author

Test failure:

TASK [openshift_logging : pulling down signing items from host] ****************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_logging/tasks/generate_jks.yaml:49
fatal: [localhost]: FAILED! => {
    "failed": true, 
    "generated_timestamp": "2017-06-29 16:19:55.618072", 
    "msg": "Failed to fetch the file: [Errno 13] Permission denied: '/tmp/openshift-logging-ansible-uQpCrq/ca.crt'"
}

@mtnbikenc
Copy link
Member Author

[test]

@openshift-bot
Copy link

The OpenShift Ansible test job could not be run again for this pull request.

  • If the proposed changes in this pull request caused the job to fail, update this pull request with new code to fix the issue(s).
  • If flaky tests caused the job to fail, leave a comment with links to the GitHub issue(s) in the openshift/origin repository with the kind/test-flake label that are tracking the flakes. If no issue already exists for the flake you encountered, create one.
  • If something else like CI system downtime or maintenance caused the job to fail, contact a member of the Team Project Committers group to trigger the job again.

@sdodson sdodson merged commit 64971dd into openshift:release-1.5 Jun 30, 2017
@mtnbikenc mtnbikenc deleted the release-1.5-fix-version-check branch June 30, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants