New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Correct version comparisons to ensure proper evaluation #4647
[3.5] Correct version comparisons to ensure proper evaluation #4647
Conversation
When a user supplies the openshift_image_tag inventory fact as '3.5', the evaluation of `version >= LooseVersion('3.5.0')` will return False. Changing the evaluation against only the X.X release will properly return True.
aos-ci-test |
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Evaluated for openshift ansible test up to 17b5de0 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/301/) (Base Commit: 5b6f45e) (PR Branch Commit: 17b5de0) |
Test failure:
|
[test] |
The OpenShift Ansible test job could not be run again for this pull request.
|
When a user supplies the openshift_image_tag inventory fact as '3.5',
the evaluation of
version >= LooseVersion('3.5.0')
will return False.Changing the evaluation against only the X.X release will properly
return True.
Backports #4645
Bug 1443416