Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for excluders #4835

Merged
merged 1 commit into from Jul 24, 2017
Merged

Use absolute path for excluders #4835

merged 1 commit into from Jul 24, 2017

Conversation

tripledes
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1474246

Use absolute path when executing excluder as it's used when checking for excluder.

Use absolute path when executing excluder as it's used when checking for excluder.
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

1 similar comment
@openshift-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

Copy link
Member

@sdodson sdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tripledes
Copy link
Contributor Author

@sdodson sorry, just noticed the unexclude.yml also use a relative path. Now that this one is merged, should I open a new one for the unexclude? Thanks!

@sdodson
Copy link
Member

sdodson commented Jul 24, 2017

@tripledes yeah that'd be great, thanks

jcantrill pushed a commit to jcantrill/openshift-ansible that referenced this pull request Aug 17, 2017
* As follow-up on openshift#4835, use absolute path also when unexcluding
ingvagabund pushed a commit to ingvagabund/openshift-ansible that referenced this pull request Aug 17, 2017
* As follow-up on openshift#4835, use absolute path also when unexcluding
ingvagabund pushed a commit to ingvagabund/openshift-ansible that referenced this pull request Aug 17, 2017
* As follow-up on openshift#4835, use absolute path also when unexcluding
ingvagabund pushed a commit to ingvagabund/openshift-ansible that referenced this pull request Aug 17, 2017
* As follow-up on openshift#4835, use absolute path also when unexcluding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants