lib/base: Allow for empty option value #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
openshift-ci-robot
added
the
size/M
|
/retest |
|
/assign kwoodson
…On Mon, Oct 2, 2017 at 9:03 AM, Jan Chaloupka ***@***.***> wrote:
/retest
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5608 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC8IQVMsrJGaWh9S7XoXyPon88KjIc2ks5soN8lgaJpZM4PpUu9>
.
|
|
/kind bug |
openshift-ci-robot
added
kind/bug
kwoodson
approved these changes
Oct 2, 2017
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/cherrypick release-3.6 |
|
@sdodson: #5608 failed to apply on top of branch "release-3.6": exit status 128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added a commit
that referenced
this pull request
Dec 18, 2017
Automatic merge from submit-queue. [3.6] GlusterFS: Backport critical fixes from 3.7 This massive PR is a backport of all the fixes that have gone into the GlusterFS portions of openshift-ansible since the fork of the release-3.6 branch. This will allow users to reliably deploy GlusterFS with new OpenShift clusters or on existing OpenShift clusters. This also fixes support for glusterblock. Includes a backport of #5608.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1483923
Signed-off-by: Jose A. Rivera jarrpa@redhat.com