Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure openshift.common.portal_net updated during scaleup. #5621

Merged

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Oct 2, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1451023

This fact is set in initialize_facts.yml at the beginning of scaleup so make sure that we update this fact if we read a different value from the first master's config file.

@abutcher abutcher requested a review from ashcrow October 2, 2017 16:19
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2017
Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the fix QE noted.

@ashcrow
Copy link
Member

ashcrow commented Oct 2, 2017

bot, retest this please

@ashcrow
Copy link
Member

ashcrow commented Oct 2, 2017

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 2, 2017
@ashcrow
Copy link
Member

ashcrow commented Oct 2, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2017
@sdodson
Copy link
Member

sdodson commented Oct 2, 2017

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2017
@sdodson
Copy link
Member

sdodson commented Oct 2, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@sdodson
Copy link
Member

sdodson commented Oct 3, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 071d8ab into openshift:master Oct 3, 2017
@abutcher abutcher deleted the scaleup-portal-net branch October 9, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants