Move openshift_data_dir to openshift.common.data_dir fact based on deployment_type #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdodson
force-pushed
the
openshift_data_dir
branch
2 times, most recently
from
3a2733f
to
5f12de7
Compare
sdodson
force-pushed
the
openshift_data_dir
branch
2 times, most recently
from
fff8a7b
to
fa2b0de
Compare
Previously this was being set to /var/lib/origin regardless of deployment_type which isn't correct given that existing 'enterprise' and 'online' deployments would have been deployed with /var/lib/openshift
sdodson
force-pushed
the
openshift_data_dir
branch
from
fa2b0de
to
12b56e7
Compare
|
@brenton QE tested that this fixes the issue for 'enterprise' deployment_type. They followed up with questions about 'origin' deployment types and I've switched 'origin' to use /var/lib/openshift as well. I think we should merge this based on QE's validation of 'enterprise' deployment_type. |
brenton
added a commit
that referenced
this pull request
Sep 10, 2015
Move openshift_data_dir to openshift.common.data_dir fact based on deployment_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was being set to /var/lib/origin regardless of deployment_type
which isn't correct given that existing 'enterprise' and 'online' deployments
would have been deployed with /var/lib/openshift