GlusterFS: Remove image option from heketi command

[jarrpa]

Reverts #5562, option has been removed from heketi command

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1502054

Signed-off-by: Jose A. Rivera jarrpa@redhat.com

[hongkailiu]

Any idea when this PR is going to be merged?

[jarrpa]

Nope. It'll get done when it gets done.

[jarrpa]

/retest

[mffiedler]

@sdodson @jarrpa Can someone help push this along? We're having to cherry pick this PR everytime we install with glusterfs options. Thanks.

[jarrpa]

@sdodson As I've tested this on my end (and we seem to have others verifying the fix as well) can you LGTM? I probably shouldn't LGTM my own PR. :)

[sdodson]

/lgtm

[sdodson]

/kind bug

[openshift-merge-robot]

Automatic merge from submit-queue.

[ttindell2]

So I am wondering why the --image command was taken out. The referenced Bugzilla bug has to do with the fact that the TOPOLOGY_PATH in the Heketi Template file was required but the ansible script did not have it specified. This happened when the files directory was split into different directories and some changes made to the 3.6 templates where not in the other templates. This has since been corrected by this commit: b8879b5. The --image command was not the issue and I believe needs to be in the template as a user should be able to specify the image repository for heketi and the version.

[jarrpa]

The underlying version of heketi changed to no longer require or even recognize the --image flag. The flag was a hack because the command that generated the copy job always used the heketi/heketi:dev image and the flag allowed for specifying an alternate image. Eventually the correct fix was introduced, which was to use the same image specified for heketi for the copy job, and thus the hack was removed.