Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Deprecation: Convert to import_playbook #6371

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Include Deprecation: Convert to import_playbook #6371

merged 1 commit into from
Dec 7, 2017

Conversation

mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Dec 6, 2017 •
edited

  • Converts playbooks/ to use import_playbook.
  • Updates remaining include: tasks to include_tasks:

Trello: https://trello.com/c/ZTyZu3UM/484-3-ansible-24-include-deprecation

@mtnbikenc mtnbikenc self-assigned this Dec 6, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2017
kwoodson
kwoodson approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@kwoodson kwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2017
@mtnbikenc
Copy link
Member Author

/retest

@mtnbikenc
Copy link
Member Author

bot, retest this please

@mtnbikenc
Copy link
Member Author

Flake openshift/origin#17330
/test install

@mtnbikenc
Copy link
Member Author

/retest

@mtnbikenc
Copy link
Member Author

bot, test this please

@kwoodson
Copy link
Contributor

kwoodson commented Dec 7, 2017

/test install

@sdodson
Copy link
Member

sdodson commented Dec 7, 2017

bot, retest this please

@mtnbikenc
Copy link
Member Author

@sdodson Install job looks like a flake and the fedora job is still broken. Are there fixes in the pipeline for these tests or should this be merged?

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2017
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2017
kwoodson
kwoodson approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@kwoodson kwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

michaelgugino
michaelgugino approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2017 •
edited

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio e64462a link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit d6ea0d5 into openshift:master Dec 7, 2017
@mtnbikenc mtnbikenc deleted the include-to-import_playbook branch December 7, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwoodson kwoodson kwoodson approved these changes

@michaelgugino michaelgugino michaelgugino approved these changes

Assignees

@kwoodson kwoodson

@michaelgugino michaelgugino

@mtnbikenc mtnbikenc

Labels
lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mtnbikenc @kwoodson @sdodson @openshift-merge-robot @openshift-ci-robot @michaelgugino