Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed_when lists are implicitely ANDs, not ORs #6815

Merged
merged 1 commit into from Jan 24, 2018
Merged

failed_when lists are implicitely ANDs, not ORs #6815

merged 1 commit into from Jan 24, 2018

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 22, 2018 •
edited

For some reason I believed failed_when lists are considered to be ORs, but it turns out these are ANDs.

Fixes bug 1534538
Relates to #6751

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2018
@vrutkovs vrutkovs changed the title Convert rc to int when checking it in failed_when failed_when lists are implicitely ANDs, not ORs Jan 22, 2018
@vrutkovs vrutkovs requested a review from sdodson January 22, 2018 17:19
@sdodson
Copy link
Member

sdodson commented Jan 22, 2018

Sorry, I thought that was intentional in the original PR. I imagine just checking for rc != 0 is sufficient to cover all cases but this minimizes additional change.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2018
@vrutkovs
Copy link
Member Author

Flakes

/retest

@mtnbikenc
Copy link
Member

/test install

mtnbikenc
mtnbikenc approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mtnbikenc
Copy link
Member

Flakes
/test install

@vrutkovs
Copy link
Member Author

flakes

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 0344a8f into openshift:master Jan 24, 2018
@openshift-ci-robot
Copy link

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 9660194 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs deleted the failed_when-rc-to-int branch January 5, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

@mtnbikenc mtnbikenc

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vrutkovs @sdodson @mtnbikenc @openshift-merge-robot @openshift-ci-robot