Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect master installed version during node upgrades #6842

Conversation

michaelgugino
Copy link
Contributor

Master version is unprotected during all upgrades.

During node-only upgrades, master version should
remain protected to ensure correct image tag is
set for node upgrades.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536839

Master version is unprotected during all upgrades.

During node-only upgrades, master version should
remain protected to ensure correct image tag is
set for node upgrades.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536839
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2018
@michaelgugino
Copy link
Contributor Author

bot, retest this please

Copy link
Contributor

@kwoodson kwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer the inverse verbage here.

openshift_update_installed_version: True
openshift_upgrade_installed_version: True

@michaelgugino, thoughts?

@michaelgugino
Copy link
Contributor Author

I think I'd prefer the inverse verbage here.

I didn't create the variable, just fixing where it is set. Either way is fine with me.

@kwoodson
Copy link
Contributor

@michaelgugino, fair enough. Maybe something to look at in the future.

Copy link
Contributor

@kwoodson kwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@sdodson
Copy link
Member

sdodson commented Jan 25, 2018

post install conformance flake

@sdodson sdodson merged commit eccd64e into openshift:master Jan 25, 2018
@openshift-ci-robot
Copy link

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp d125aa5 link /test gcp
ci/openshift-jenkins/logging d125aa5 link /test logging
ci/openshift-jenkins/install d125aa5 link /test install
ci/openshift-jenkins/extended_conformance_install_crio d125aa5 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. priority/P1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants