New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect master installed version during node upgrades #6842
Protect master installed version during node upgrades #6842
Conversation
Master version is unprotected during all upgrades. During node-only upgrades, master version should remain protected to ensure correct image tag is set for node upgrades. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536839
bot, retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer the inverse verbage here.
openshift_update_installed_version: True
openshift_upgrade_installed_version: True
@michaelgugino, thoughts?
I didn't create the variable, just fixing where it is set. Either way is fine with me. |
@michaelgugino, fair enough. Maybe something to look at in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test all [submit-queue is verifying that this PR is safe to merge] |
post install conformance flake |
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Master version is unprotected during all upgrades.
During node-only upgrades, master version should
remain protected to ensure correct image tag is
set for node upgrades.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536839