New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally create pvcs for metrics depending on whether or not it … #6960
Conversation
@jsanda can you take a look? |
a944d0f
to
5341e36
Compare
bot, retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
bot, retest this please |
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test gcp |
those are all flakes. |
/cherrypick release-3.7 |
@ewolinetz: new pull request created: #7000 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ewolinetz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…6960-to-release-3.7 Automatic merge from submit-queue. [release-3.7] Conditionally create pvcs for metrics depending on whether or not it … This is an automated cherry-pick of #6960 /assign ewolinetz
…already exists
This is similar to the logic we implemented in logging to prevent messages like:
"The PersistentVolumeClaim "metrics-cassandra-3" is invalid: spec: Forbidden: field is immutable after creation"
If the pvc already exists we won't generate a template for it to later oc apply.
This is to address https://bugzilla.redhat.com/show_bug.cgi?id=1540729