Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally create pvcs for metrics depending on whether or not it … #6960

Merged
merged 1 commit into from Feb 2, 2018

Conversation

ewolinetz
Copy link
Contributor

…already exists

This is similar to the logic we implemented in logging to prevent messages like:
"The PersistentVolumeClaim "metrics-cassandra-3" is invalid: spec: Forbidden: field is immutable after creation"

If the pvc already exists we won't generate a template for it to later oc apply.

This is to address https://bugzilla.redhat.com/show_bug.cgi?id=1540729

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2018
@mwringe
Copy link
Contributor

mwringe commented Jan 31, 2018

@jsanda can you take a look?

@ewolinetz ewolinetz requested a review from jsanda January 31, 2018 22:40
@ewolinetz
Copy link
Contributor Author

bot, retest this please

Copy link
Contributor

@mwringe mwringe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewolinetz
Copy link
Contributor Author

/retest

@ewolinetz
Copy link
Contributor Author

bot, retest this please

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Feb 2, 2018 via email

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Feb 2, 2018 via email

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@ewolinetz
Copy link
Contributor Author

/test gcp

@sdodson
Copy link
Member

sdodson commented Feb 2, 2018

those are all flakes.

@sdodson sdodson merged commit d057d39 into openshift:master Feb 2, 2018
@ewolinetz
Copy link
Contributor Author

/cherrypick release-3.7

@openshift-cherrypick-robot

@ewolinetz: new pull request created: #7000

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@ewolinetz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/install 5341e36 link /test install
ci/openshift-jenkins/gcp 5341e36 link /test gcp
ci/openshift-jenkins/extended_conformance_install_crio 5341e36 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot added a commit that referenced this pull request Feb 3, 2018
…6960-to-release-3.7

Automatic merge from submit-queue.

[release-3.7] Conditionally create pvcs for metrics depending on whether or not it …

This is an automated cherry-pick of #6960

/assign ewolinetz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants