cherry-pick to 3.6 gluster block

[mjudeikis]

No description provided.

[mjudeikis]

/hold

[mjudeikis]

@jarrpa this one still kicking... testing now...

[mjudeikis]

looks like same dynamic inventory case here:

    glusterfs_nodes: "{{ groups.glusterfs_registry | default(groups.glusterfs) }}"

to

    glusterfs_nodes: "{{ groups.glusterfs_registry if groups.glusterfs_registry | lenght > 0 else groups.glusterfs }}"

Because of this endpoints templates gets evaluates wrong... testing the fix before committing... But it might be fixed again for all branches...

[jarrpa]

We don't want to hold up these PRs for this dynamic inventory stuff, and in particular I don't want it on QE's radar to test for it. If you can, push through without it and we'll backport the group fixes separately.

[mjudeikis]

this one does not hold... But it fails due firewall now... I move forward overwriting those using debug mode, but now storage failing to provision.

I suspect slightly different firewall management comparing to 3.7+ branch... Will test it again first thing in the morning...

[jarrpa]

@mjudeikis Always run tox on your end.

[mjudeikis]

@jarrpa for this we were firewall... so Copied it from 3.7+ but because plays are little bit different, added it just before Pods are created. Other option would be included before config... any ideas?

[mjudeikis]

/hold cancel

[jarrpa]

@mjudeikis Put the firewall include before the node labeling task.

[mjudeikis]

@jarrpa did it but would like to know your thinking behind this. I was thinking to do this just before deployment of the pods as its one pre-req needed for nodes. So if anything fails before deployment of pods, we would not leave residual firewalls rules open.

[jarrpa]

In 3.7+ all the firewall modifications get done before the main role tasks even run, so there's precedent for this. I just like having it at early as reasonably possible, and I figured just after any wipe operations was good enough.

[jarrpa]

/lgtm

[jarrpa]

/test crio

[mjudeikis]

/retest

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@mjudeikis: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_crio	434605b	link	/test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue.