Run init/facts for docker upgrade

[michaelgugino]

playbooks/init fact plays must almost always
be run.

This commit adds the init code in the necessary
position to ensure that the facts are run.

This commit also cleans up booleans to use
multi-line lists instead of 'and' conditions.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1542397

[mtnbikenc]

Bringing init/main.yml in at this point causes evaluate_groups.yml to be run a third time. It might be better to move init/main.yml up to byo/openshift-cluster/upgrades/docker/upgrade.yml and pass in the vars for keeping g_new_*_hosts empty. That way we run through evaluate_groups once. Ultimately, I think this docker upgrade stuff should be refactored to go into the playbooks/container_runtime component once we get to upgrade refactoring.

[michaelgugino]

Bringing init/main.yml in at this point causes evaluate_groups.yml to be run a third time. It might be better to move init/main.yml up to byo/openshift-cluster/upgrades/docker/upgrade.yml and pass in the vars for keeping g_new_*_hosts empty. That way we run through evaluate_groups once. Ultimately, I think this docker upgrade stuff should be refactored to go into the playbooks/container_runtime component once we get to upgrade refactoring.

@mtnbikenc evaluate_groups runs as an action on localhost. Running evaluate_groups multiple times adds a very trivial amount of tasks and runtime.

I don't want to do any more refactoring this cycle. The alternative to this patch would be to manually include the facts plays. Which do you prefer?

[mtnbikenc]

I'd like this approach to change when we refactor upgrades. For now, I think the evaluate_groups.yml should be removed from the byo entry point because not allowing hosts to be added is not being enforced.

https://github.com/openshift/openshift-ansible/blob/master/playbooks/byo/openshift-cluster/upgrades/docker/upgrade.yml#L3

[mtnbikenc]

/lgtm

[michaelgugino]

/test gcp

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/gcp	4317a7b	link	/test gcp
ci/openshift-jenkins/logging	4317a7b	link	/test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.