New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target mount for gluster block #7198
Add target mount for gluster block #7198
Conversation
LGTM |
/retest |
minor comment: /s/glusterfs-target/glusterfs-block/ |
This is my question too... Should we be following host path naming convention (as it is now) or should we do purpose based (as per suggestion). I prefer host path naming convention for HostPath and Purpose for config/secrets/volumes as it makes debugging much easier when tracking volume names. |
This is backporting an existing feature in the templates of cns-deploy, where we named it /lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
@mjudeikis Can you reference "Resolves: #7198" and any relevant BZs in the initial comment / description? |
/retest |
@jarrpa done. +1 for consolidation plan ;) |
/retest |
1 similar comment
/retest |
Automatic merge from submit-queue. |
Adding target folder mount for gluster block to persist configuration.
Resolves: #7198
BZ: 1540080