Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_api_server: service catalog healthcheck doesn't require proxy #7262

Merged
merged 1 commit into from Feb 23, 2018

Conversation

vrutkovs
Copy link
Member

This change would restore no_proxy param set by #7125 and reverted by #7222

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1544645

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2018
@vrutkovs
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 74451c5 link /test gcp
ci/openshift-jenkins/system-containers 74451c5 link /test system-containers
ci/openshift-jenkins/install 74451c5 link /test install
ci/openshift-jenkins/extended_conformance_install_crio 74451c5 link /test crio
ci/openshift-jenkins/logging 74451c5 link /test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson merged commit 30a450e into openshift:master Feb 23, 2018
@vrutkovs
Copy link
Member Author

/cherry-pick release-3.7

@vrutkovs
Copy link
Member Author

/cherrypick release-3.7

@openshift-cherrypick-robot

@vrutkovs: #7262 failed to apply on top of branch "release-3.7":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	roles/openshift_service_catalog/tasks/start_api_server.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_service_catalog/tasks/start_api_server.yml
CONFLICT (content): Merge conflict in roles/openshift_service_catalog/tasks/start_api_server.yml
Patch failed at 0001 start_api_server: service catalog healthcheck doesn't require proxy

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor

nak3 commented Mar 15, 2018

@vrutkovs is there any chance to add same no_proxy param for *.svc? I reported #7338 though...

@vrutkovs vrutkovs deleted the service-catalog-no-proxy branch January 5, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants