[3.7] etcd migrate: instead of scaleup playbook etcd server should be started back #7313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
michaelgugino
approved these changes
Feb 27, 2018
| roles: | ||
| - openshift_etcd_facts | ||
|
|
||
| - name: Re-configure etcd and bring the cluster up |
There was a problem hiding this comment.
This looks okay to me. Please update with test results.
There was a problem hiding this comment.
Had to add a few more vars, now migrates 3.7 cluster correctly
…ed back master doesn't need to be restarted and etcd URLs updated as new etcd nodes are being added. There is no need to run scaleup playbook, as etcd nodes are already added to the cluster. The migrate procedure now does the following: * checks if the etcd data needs to be migrated * makes etcd backup * stops etcd services on all nodes except the first one * migrates etcd data on first etcd node * clears data on other etcd nodes * updates etcd cluster configuration, updating ETCD_INITIAL_CLUSTER and ETCD_INITIAL_CLUSTER_STATE * starts the etcd service again one by one on etcd nodes Now the only copy of migrated data is on the first etcd cluster, which would replicate it to other nodes. After migration is done master configs are updated and services restarted if needed
vrutkovs
force-pushed
the
3.7-migrate-start-etcd-and-check-health
branch
from
b53a096
to
7e30cda
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test install |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7226
Replaces #7297
Verified to be working on 3.7 cluster