Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for using an external openvswitch #7321

Merged
merged 1 commit into from Mar 1, 2018

Conversation

flaper87
Copy link
Contributor

This commit allows for relying on an existing openvswitch deployment for the Openshift SDN. This is particularly useful for environments where the openvswitch deployment is shared by multiple services or managed by external resources.

As an example, we're looking into using TripleO - on OpenStack deployment tool - as the tool to provision and prepare the baremetal nodes where OpenShift and OpenStack will run. TripleO lays down the network infrastructure, which is then consumed in these nodes. Instead of re-deploying openvswitch in containers, which currently destroys the existing configuration, openshift-ansible could allow for re-using the existing openvswitch instance.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2018
@sdodson
Copy link
Member

sdodson commented Feb 28, 2018

/test install

@bogdando
Copy link
Contributor

@michaelgugino PTAL

@@ -113,6 +113,7 @@ system_images_registry_dict:
origin: "docker.io"

system_images_registry: "{{ system_images_registry_dict[openshift_deployment_type | default('origin')] }}"
l_openshift_use_external_openvswitch: "{{ openshift_use_external_openvswitch | default(false) }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to use the l_ prefix and indirect here. This variable is only going to apply to the node role.

Just use

openshift_use_external_openvswitch: False

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, will change! :D

Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2018
@flaper87
Copy link
Contributor Author

flaper87 commented Mar 1, 2018

/test gcp

@flaper87
Copy link
Contributor Author

flaper87 commented Mar 1, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@flaper87
Copy link
Contributor Author

flaper87 commented Mar 1, 2018

/test tox

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2018

@flaper87: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio d20421a link /test crio
ci/openshift-jenkins/system-containers d20421a link /test system-containers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 66e1b9d into openshift:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants