New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for using an external openvswitch #7321
Conversation
/test install |
@michaelgugino PTAL |
@@ -113,6 +113,7 @@ system_images_registry_dict: | |||
origin: "docker.io" | |||
|
|||
system_images_registry: "{{ system_images_registry_dict[openshift_deployment_type | default('origin')] }}" | |||
l_openshift_use_external_openvswitch: "{{ openshift_use_external_openvswitch | default(false) }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to use the l_ prefix and indirect here. This variable is only going to apply to the node role.
Just use
openshift_use_external_openvswitch: False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, will change! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test gcp |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
/test tox |
/test all [submit-queue is verifying that this PR is safe to merge] |
@flaper87: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. |
This commit allows for relying on an existing openvswitch deployment for the Openshift SDN. This is particularly useful for environments where the openvswitch deployment is shared by multiple services or managed by external resources.
As an example, we're looking into using
TripleO
- on OpenStack deployment tool - as the tool to provision and prepare the baremetal nodes where OpenShift and OpenStack will run. TripleO lays down the network infrastructure, which is then consumed in these nodes. Instead of re-deploying openvswitch in containers, which currently destroys the existing configuration, openshift-ansible could allow for re-using the existing openvswitch instance.