New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master scheduler upgrade cleanup #7333
Master scheduler upgrade cleanup #7333
Conversation
Currently, all these tasks are being skipped. I think this is a bug problem with import_role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test all [submit-queue is verifying that this PR is safe to merge] |
/hold |
6f14e9a
to
bef2a98
Compare
bef2a98
to
20f5a6a
Compare
/hold cancel |
This commit cleans up nested blocks which are hard to read, gives names to all tasks so we can debug the output better. This commit also removes openshift.common.short_version from predicate/priority lookup plugins as that data may be stale. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549971
20f5a6a
to
56eaa15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick release-3.9 |
@sdodson: new pull request created: #7362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Master scheduler upgrade cleanup
This commit cleans up nested blocks which are hard
to read, gives names to all tasks so we can
debug the output better.
This commit also removes openshift.common.short_version
from predicate/priority lookup plugins as that data
may be stale.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549971