TSB upgrade remove and reinstall

[michaelgugino]

Daemonsets can't be updated in the same way as
deployment configs.

This commit instructs upgrade to first remove
then reintsall tsb.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1540521

[michaelgugino]

/cherrypick release-3.9

[openshift-cherrypick-robot]

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

/cherry-pick release-3.9

[sdodson]

/lgtm

[sdodson]

Seems heavy handed but should work given what we've been told about the statelessness of TSB.

[michaelgugino]

@sdodson it does seem a little heavy handed, but just trying to get something solid for QE. I'm not experienced in these daemon sets and all these templates and whatnot.

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-ci-robot]

@michaelgugino: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/logging	658bdf0	link	/test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue.

[openshift-cherrypick-robot]

@michaelgugino: new pull request created: #7439

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jpeeler]

This fix confuses me. Daemonsets can be upgraded like deployments, they just aren't set to do that by default. I corrected this here: #7374. Edit: I see now the former was reverted: #7474.

[michaelgugino]

@jpeeler We reverted this commit because it was unnecessary.

[sdodson]

Yeah, the build QE tested didn't have that fix in.