[3.7] Pop etcd_port from local_facts file #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables are hanging around in openshift.facts fact file on hosts that shouldn't be. This causes old versions of defaults to take precedence over new default values in openshift_facts. This commit pops master.etcd_port from the facts being saved to disk. This allows the correct default port for etcd to take effect. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1546365 (cherry picked from commit 938d8dd)
openshift-ci-robot
added
the
size/S
michaelgugino
changed the title
|
Let's hold this on qe verifying the upstream bug. |
openshift-ci-robot
added
do-not-merge/hold
|
/hold cancel This has merged in master. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
@michaelgugino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variables are hanging around in openshift.facts
fact file on hosts that shouldn't be.
This causes old versions of defaults to take precedence
over new default values in openshift_facts.
This commit pops master.etcd_port from the facts being
saved to disk. This allows the correct default port
for etcd to take effect.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1546365
(cherry picked from commit 938d8dd)