Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crlnumber file missing during 'openshift_logging' install #7764

Merged
merged 1 commit into from Apr 5, 2018
Merged

Conversation

oybed
Copy link
Member

@oybed oybed commented Apr 3, 2018

This is a proposed fix for issue #7725.

I have tested this change on a real system and it fixes the issue outlined in #7725. I.e.: tested with OCP 3.7.23 on RHEL7.4 with openshift-ansible release-3.7 branch.

I am not 100% certain that this is the correct solution, however, so would like to have someone more familiar with this area review to double check. Maybe @ewolinetz can chime in as I see he was the original author of this area?

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 3, 2018
@oybed oybed changed the title Fixing crlnumber file missing Fixing crlnumber file missing during 'openshift_logging' install Apr 3, 2018
@sdodson sdodson requested a review from ewolinetz April 5, 2018 12:26
@sdodson
Copy link
Member

sdodson commented Apr 5, 2018

Also reported https://bugzilla.redhat.com/show_bug.cgi?id=1562966 I believe

@ewolinetz
Copy link
Contributor

@oybed This is the correct fix for this, thanks. Looking through the rest of the code I'm not sure why this hasn't failed before... we definitely want ca.crl.srl because we specify it in our signing.conf file.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2018
@openshift-merge-robot openshift-merge-robot merged commit f1d3140 into openshift:master Apr 5, 2018
@ewolinetz
Copy link
Contributor

/cherrypick release-3.9

@ewolinetz
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot

@ewolinetz: new pull request created: #7814

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ewolinetz: new pull request created: #7815

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants