Adjust Kuryr CNI definitions for new Docker image #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
This currently needs to wait for upstream change to get merged. |
|
/retest |
|
/test gcp |
|
/lgtm |
|
/retest |
|
/lgtm |
New Kuryr CNI Docker images are using `docker exec` instead of `docker run` to execute CNI binary. This required a few changes to CNI resources definitions. In particular: * host's /etc directory is no longer mounted into CNI container. * `KURYR_CNI_POD_NAME` environment variable is added and it's supposed to hold CNI pod name for cni_ds_init to be able to identify the pod. * `lock_path` option of oslo_concurrency is no longer needed to be set, default value is defined by OSLO_LOCK_PATH environment variable.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Kuryr CNI Docker images are using
docker execinstead ofdocker runto execute CNI binary. This required a few changes to CNI resourcesdefinitions. In particular:
KURYR_CNI_POD_NAMEenvironment variable is added and it's supposedto hold CNI pod name for cni_ds_init to be able to identify the pod.
lock_pathoption of oslo_concurrency is no longer needed to be set,default value is defined by OSLO_LOCK_PATH environment variable.