always add es and es-ops hostname to the es server cert #7931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/test gcp |
ewolinetz
reviewed
Apr 12, 2018
| @@ -64,7 +64,7 @@ | |||
| when: not elasticsearch_jks.stat.exists or not logging_es_jks.stat.exists or not system_admin_jks.stat.exists or not truststore_jks.stat.exists | |||
|
|
|||
| - name: Run JKS generation script | |||
| local_action: script generate-jks.sh {{local_tmp.stdout}} {{openshift_logging_namespace}} | |||
| local_action: script generate-jks.sh {{local_tmp.stdout}} {{openshift_logging_namespace}} {{openshift_logging_es_hostname | default(omit)}} {{openshift_logging_es_ops_hostname | default(omit)}} | |||
There was a problem hiding this comment.
does omit actually work? I've just done default() in the past to null it out
There was a problem hiding this comment.
@ewolinetz good question - there are many other places in the openshift-ansible code where default(omit) is used for a similar purpose
|
/retest |
|
/lgtm |
|
/test gcp |
1 similar comment
|
/test gcp |
|
/test travis |
|
/test travis-ci |
|
/retest |
|
tests passing - can I get a /lgtm? |
|
/cherrypick release-3.9 |
|
@richm: new pull request created: #7940 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add X509v3 Subject Alternative Name items to the Elasticsearch
server cert like this:
This allows external Elasticsearch clients using client cert auth
and the Elasticsearch service using externalIPs to be able to turn
on cert verification.