[3.6] etcd upgrade: move validate_etcd_conf.yml to etcd_upgrade role

[vrutkovs]

Follow-up for #7781, moves config yaml to the etcd_upgrade role.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1567857

No cherrypick required for 3.7+ branches, as these use etcd role for upgrade

[michaelgugino]

I'm not following what's going on here. It's just a file being deleted, nothing is moved.

[sdodson]

@michaelgugino In release-3.7 there is no etcd_upgrade role where as in release-3.6 there is and that's where the majority of the changes in #7781 were made but the file referenced here is in the wrong role. It wasn't backported proplery.

@vrutkovs I think maybe you forgot to add roles/etcd_upgrade/tasks/validate_etcd_conf.yml to your commit? this only has deletion of the bad file rather than moving to the proper path.

[vrutkovs]

Ugh, indeed, my fault

[michaelgugino]

@vrutkovs Is there something calling this task_file that is currently failing? How is this supposed to be executed?

[sdodson]

@michaelgugino it's called here https://github.com/openshift/openshift-ansible/pull/7781/files#diff-93f3128ff64af28c7c6ebb47e792aaacR23

[sdodson]

/lgtm

[mtnbikenc]

/lgtm

[mtnbikenc]

/retest

[mtnbikenc]

/retest

[vrutkovs]

/retest

[openshift-ci-robot]

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/system-containers	1ad23c6	link	/test system-containers
ci/openshift-jenkins/install	1ad23c6	link	/test install
ci/openshift-jenkins/logging	1ad23c6	link	/test logging

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.