New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few remaining image expansions #8122
Conversation
@@ -41,7 +41,7 @@ l_openshift_prefix_dict: | |||
openshift-enterprise: 'ose-${component}' | |||
l_os_prefix: "{{ l_openshift_prefix_dict[openshift_deployment_type] }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears l_os_prefix is not used any more? Also l_openshift_prefix_dict ?
Same for other file and vars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, removed them all.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1570257 Remove unused l_os_prefix and l_openshift_prefix_dict as these are unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
bot, retest this please |
/test gcp |
1 similar comment
/test gcp |
@sdodson: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Same flake |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1570257