Cleanup systemcontainer bits #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
size/L
michaelgugino
force-pushed
the
container-runtime-syscon-remove
branch
from
4be6901
to
ab35bc3
Compare
sdodson
approved these changes
May 10, 2018
This commit removes many systemcontainer tuneables, especially around container_runtime. etcd system container tunables are left in place in some files to aid in determining current installation type for migration during upgrades. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1565078
michaelgugino
force-pushed
the
container-runtime-syscon-remove
branch
from
ab35bc3
to
0bb013f
Compare
Probably. This patch is large enough, I also feel with crio and whatnot we might need this variable again in the future. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes many systemcontainer tuneables,
especially around container_runtime.
etcd system container tunables are left in place
in some files to aid in determining current installation
type for migration during upgrades.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1565078