Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply app label to console replica sets and pods #8637

Merged
merged 1 commit into from Jun 5, 2018

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jun 5, 2018

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2018
@spadgett
Copy link
Member Author

spadgett commented Jun 5, 2018

/cherrypick release-3.9

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett changed the title [WIP] Apply app label to console replica sets and pods Apply app label to console replica sets and pods Jun 5, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2018
@spadgett
Copy link
Member Author

spadgett commented Jun 5, 2018

@sdodson I've verified that this fixes the problem

@spadgett
Copy link
Member Author

spadgett commented Jun 5, 2018

Stage PROVISION CLOUD RESOURCES [00h 10m 33s] failed.

/retest

@sdodson
Copy link
Member

sdodson commented Jun 5, 2018

bot, retest this please

@sdodson
Copy link
Member

sdodson commented Jun 5, 2018

/test gcp-upgrade

@sdodson
Copy link
Member

sdodson commented Jun 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2018
@sdodson
Copy link
Member

sdodson commented Jun 5, 2018

@spadgett The fedora failures seem legit, can you take a look at them? I wonder why they're only happening there. here's the inventory used by these jobs https://github.com/openshift/openshift-ansible/blob/master/.papr.all-in-one.inventory

STDERR:

'app' already has a value (openshift-web-console), and --overwrite is false
'app' already has a value (openshift-web-console), and --overwrite is false

@spadgett
Copy link
Member Author

spadgett commented Jun 5, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2018
@spadgett
Copy link
Member Author

spadgett commented Jun 5, 2018

/hold cancel

thanks for catching that @sdodson, updated

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2018
@sdodson
Copy link
Member

sdodson commented Jun 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp-upgrade bae5d74 link /test gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson merged commit 6011558 into openshift:master Jun 5, 2018
@openshift-cherrypick-robot

@spadgett: new pull request created: #8642

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants