Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop --confirm from migrate storage invocation #8781

Merged
merged 1 commit into from Aug 2, 2018

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Jun 15, 2018

Per openshift/origin#19691 drop the --confirm flag from storage migration operations.

/assign @sdodson @vrutkovs

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2018
@soltysh
Copy link
Member Author

soltysh commented Jun 15, 2018

This applies ONLY to 3.10 and higher, which is super important.

@sdodson
Copy link
Member

sdodson commented Jun 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2018
@soltysh
Copy link
Member Author

soltysh commented Jun 15, 2018

@enj fyi, since you authored the original PR

@enj
Copy link
Contributor

enj commented Jun 15, 2018

LGTM as long as it can never be used with an older oc.

@sdodson
Copy link
Member

sdodson commented Jun 15, 2018

LGTM as long as it can never be used with an older oc.

hmm, the pre-upgrade migration will run with 3.9 oc. I guess we should hold this until we branch release-3.10 and consider this for 3.11. It's just a warning of deprecation in 3.10, right?

@sdodson
Copy link
Member

sdodson commented Jun 15, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2018
@enj
Copy link
Contributor

enj commented Jun 15, 2018

Yeah the command just warns and ignores the user's input (confirm is always true).

@sdodson
Copy link
Member

sdodson commented Aug 2, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2018
@sdodson
Copy link
Member

sdodson commented Aug 2, 2018

/retest
this will probably fail

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 2, 2018

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp-upgrade abcac82 link /test gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Aug 2, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit ad5b7fa into openshift:master Aug 2, 2018
@soltysh soltysh deleted the drop_confirm branch August 13, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants