Wait for API availability before migrating storage, add retries

[sdodson]

Wait for all core apis to become available and add more retries to the
storage migration to work around a problem where storage migration fails
due to certain api endpoints not being available in time

Potential fix for https://bugzilla.redhat.com/show_bug.cgi?id=1591053

[mtnbikenc]

@sdodson This doesn't call into the task that checks all core APIs. That task is at the end of main.yml and will require some refactoring to be able to call it directly. There are a lot of checks here which could be useful to run at different stages but I don't know that we need to completely rework it at this point. Increasing retries looks fine.

[sdodson]

Ugh, can't believe I missed that. I've moved the core api checks into the included task file, i think it's a good generic check for api availability now.

[mtnbikenc]

/lgtm

[sdodson]

Fixed an undefined variable error i encountered in testing.

TASK [openshift_control_plane : fail] *****************************************************************************************************************************************************************************
task path: /home/rdu/sdodson/git/openshift-ansible/roles/openshift_control_plane/tasks/check_master_api_is_ready.yml:21
Friday 06 July 2018  13:27:17 -0400 (0:00:00.037)       0:23:25.585 *********** 
fatal: [ose3-master.example.com]: FAILED! => {
    "failed": true, 
    "msg": "The conditional check 'l_api_available_output.stdout != 'ok'' failed. The error was: error while evaluating conditional (l_api_available_output.stdout != 'ok'): 'l_api_available_output' is undefined\n\nThe error appears to have been in '/home/rdu/sdodson/git/openshift-ansible/roles/openshift_control_plane/tasks/check_master_api_is_ready.yml': line 21, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- fail:\n  ^ here\n"
}

[mtnbikenc]

I hit the same error in my test.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mtnbikenc,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdodson]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@sdodson: new pull request created: #9099

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.