Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] Allow the 9k-10k port range for Prometheus #9172

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #9072

/assign vrutkovs

This ensures that Prometheus is able to monitor services such as
node_exporter, alertmanager and prometheus itself.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mtnbikenc

If they are not already assigned, you can assign the PR to them by writing /assign @mtnbikenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2018
@vrutkovs
Copy link
Member

Holding until 3.10.z release

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2018
@0xmichalis
Copy link
Contributor

/test all

1 similar comment
@mjudeikis
Copy link
Contributor

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2018

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp-upgrade 09d056f link /test gcp-upgrade
ci/openshift-jenkins/gcp 09d056f link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

@vrutkovs it seems that the gcp job is always failing on:

TASK [openshift_master_certificates : Generate the loopback master client config] ***
Tuesday 31 July 2018  11:20:11 +0000 (0:00:02.157)       0:13:28.052 ********** 
changed: [prtest-3b74bcd-289-ig-m-3wt3 -> 35.231.234.186] => (item=prtest-3b74bcd-289-ig-m-q38v)
changed: [prtest-3b74bcd-289-ig-m-3wt3 -> 35.231.234.186] => (item=prtest-3b74bcd-289-ig-m-qcc8)
ERROR! |failed expects hostvars is a dict

You commented on #7596 (comment) that it shouldn't affect 3.10 though. Any clue of what is happening?

@vrutkovs
Copy link
Member

vrutkovs commented Aug 3, 2018

@simonpasquier see openshift/release#1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants