Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.9] Allow the 9k-10k port range for Prometheus #9258

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #9072

/assign simonpasquier

This ensures that Prometheus is able to monitor services such as
node_exporter, alertmanager and prometheus itself.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: simonpasquier.

Note that only openshift members and repo collaborators can be assigned.

In response to this:

This is an automated cherry-pick of #9072

/assign simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/test gcp

@simonpasquier
Copy link
Contributor

@simonpasquier
Copy link
Contributor

/test gcp

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 6af6248 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

@vrutkovs @sdodson this is similar to #9072

@sdodson sdodson merged commit 7dced00 into openshift:release-3.9 Aug 2, 2018
@bamb00
Copy link

bamb00 commented Mar 29, 2019

@simonpasquier Sorry for the newbie question. I would thought this would be a node-exporter issue. If I deploy prometheus chart from helm/stable and the node-exporter gets installed along with the deployment. The node-exporter should open the port 9100 during the installation. This would avoid the headache of manually opening the port for each node in the control plane and data plane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants