Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glusterfs storageclass heketi url #9326

Merged

Conversation

michaelgugino
Copy link
Contributor

This commit removes errant extra .svc from url
for glusterfs storageclass.

This commit removes errant extra .svc from url
for glusterfs storageclass.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2018
@michaelgugino
Copy link
Contributor Author

/cherrypick release-3.10

@openshift-cherrypick-robot

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link
Contributor Author

/cherrypick release-3.9

@openshift-cherrypick-robot

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member

Looks good, Gluster PVC can be provisioned - lets see if Jose likes this

Copy link
Contributor

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoops! Yeah, LGTM.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson merged commit db2ca31 into openshift:master Jul 25, 2018
@openshift-cherrypick-robot

@michaelgugino: #9326 failed to apply on top of branch "release-3.10":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	roles/openshift_storage_glusterfs/templates/glusterfs-storageclass.yml.j2
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_storage_glusterfs/templates/glusterfs-storageclass.yml.j2
CONFLICT (content): Merge conflict in roles/openshift_storage_glusterfs/templates/glusterfs-storageclass.yml.j2
Patch failed at 0001 Fix glusterfs storageclass heketi url

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@michaelgugino: #9326 failed to apply on top of branch "release-3.9":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	roles/openshift_storage_glusterfs/templates/glusterfs-storageclass.yml.j2
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_storage_glusterfs/templates/v3.8/glusterfs-storageclass.yml.j2
CONFLICT (content): Merge conflict in roles/openshift_storage_glusterfs/templates/v3.8/glusterfs-storageclass.yml.j2
Patch failed at 0001 Fix glusterfs storageclass heketi url

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor

nak3 commented Aug 16, 2018

Thank you @michaelgugino it was my typo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants