Fix ASB user and password defaults

[jmontleon]

@fabianvf @sdodson This should be the python null, None. Not the ansible null, null.

The task then passes successfully:

TASK [ansible_service_broker : Set default image variables based on deployment type] ******************************************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/roles/ansible_service_broker/tasks/facts.yml:3
ok: [192.168.121.126.nip.io] => (item=/usr/share/ansible/openshift-ansible/roles/ansible_service_broker/vars/openshift-enterprise.yml) => {
    "ansible_facts": {
        "__ansible_service_broker_registry_name": "rh", 
        "__ansible_service_broker_registry_organization": null, 
        "__ansible_service_broker_registry_password": "{{ oreg_auth_password | default(None) }}", 
        "__ansible_service_broker_registry_tag": "{{ openshift_image_tag }}", 
        "__ansible_service_broker_registry_type": "rhcc", 
        "__ansible_service_broker_registry_url": "https://registry.redhat.io", 
        "__ansible_service_broker_registry_user": "{{ oreg_auth_user | default(None) }}", 
        "__ansible_service_broker_registry_whitelist": [
            ".*-apb$"
        ]
    }, 
    "ansible_included_var_files": [
        "/usr/share/ansible/openshift-ansible/roles/ansible_service_broker/vars/openshift-enterprise.yml"
    ], 
    "changed": false, 
    "item": "/usr/share/ansible/openshift-ansible/roles/ansible_service_broker/vars/openshift-enterprise.yml"
}

TASK [ansible_service_broker : set ansible_service_broker facts] **************************************************************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/roles/ansible_service_broker/tasks/facts.yml:9
ok: [192.168.121.126.nip.io] => {
    "ansible_facts": {
        "ansible_service_broker_registry_name": "dh", 
        "ansible_service_broker_registry_organization": "", 
        "ansible_service_broker_registry_password": "", 
        "ansible_service_broker_registry_tag": "v3.11.0", 
        "ansible_service_broker_registry_type": "rhcc", 
        "ansible_service_broker_registry_url": "http://asb-registry.usersys.redhat.com:5000", 
        "ansible_service_broker_registry_user": "", 
        "ansible_service_broker_registry_whitelist": [
            ".*-apb$"
        ]
    }, 
    "changed": false
}

[sdodson]

/cc @fabianvf

[fabianvf]

Oops
/approve

[sdodson]

/lgtm

[sdodson]

This was changed recently on master branch here, https://github.com/jmontleon/openshift-ansible/commit/0820b071503d2a045b59177fe70ba7a0d2035396
I'm not sure if this is a problem prior to that commit or not? What do you think @fabianvf

[fabianvf]

@sdodson I don't think so, I think the error arises from using null in the jinja block, when it's just in the yaml it's properly interpreted.

[jmontleon]

That's my understanding as well.

[sdodson]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, jmontleon, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• roles/ansible_service_broker/OWNERS [fabianvf,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment