Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "health checks: use etcd_image as it would work on Origin correctly" #9461

Merged
merged 1 commit into from Aug 8, 2018
Merged

Revert "health checks: use etcd_image as it would work on Origin correctly" #9461

merged 1 commit into from Aug 8, 2018

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Aug 7, 2018

This reverts commit 1f1eb5d.

The fix in this commit doesn't seem to fix system containers and breaks
existing inventories.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612863

@vrutkovs
Revert "health checks: use etcd_image as it would work on Origin corr…
cb234b6 
…ectly"

This reverts commit 1f1eb5d.

The fix in this commit doesn't seem to fix system containers and breaks
existing inventories.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1612863
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2018
michaelgugino
michaelgugino approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 8, 2018

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 8, 2018

/approve

@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 8, 2018

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelgugino, vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp cb234b6 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs merged commit 95a7a39 into openshift:release-3.9 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

Assignees

@michaelgugino michaelgugino

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrutkovs @openshift-ci-robot @michaelgugino