Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in origin imagestream+template updates #9504

Merged
merged 1 commit into from Aug 10, 2018
Merged

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Aug 9, 2018

Note that i explicitly did not include any of the xpaas imagestream+template changes as that would revert the change to the new registry which isn't in the upstream version of that content.

bug https://bugzilla.redhat.com/show_bug.cgi?id=1614156

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: michaelgugino

If they are not already assigned, you can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2018
@bparees
Copy link
Contributor Author

bparees commented Aug 9, 2018

@sdodson ptal.

also "latest" currently points to "v3.10" in the examples dir. Do you want me to update it to point to v3.11 here?

@bparees bparees force-pushed the repos branch 2 times, most recently from b9c9e04 to 6ab4e47 Compare August 9, 2018 14:54
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2018
@bparees
Copy link
Contributor Author

bparees commented Aug 9, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2018
@bparees
Copy link
Contributor Author

bparees commented Aug 9, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2018
@bparees
Copy link
Contributor Author

bparees commented Aug 9, 2018

ok i think this is good to go...you can just review the v3.11 dir changes primarily, everything else is deletions.

@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

/retest

@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

/lgtm

@vrutkovs
Copy link
Member

/retest

@openshift-ci-robot
Copy link

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 217563e link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson merged commit 6f86425 into openshift:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants