Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registry log level tuning #9821

Merged

Conversation

cooktheryan
Copy link
Contributor

@cooktheryan cooktheryan commented Aug 29, 2018

Set the default log level to info and allow for the variable to be defined.

Fixes #9820

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2018
@bparees
Copy link
Contributor

bparees commented Aug 29, 2018

/assign @legionus

@sdodson sdodson changed the title issue #9820 Allow registry log level tuning Aug 29, 2018
@sdodson
Copy link
Member

sdodson commented Aug 29, 2018

/approve
lgtm too but didn't know if we wanted to wait on @legionus to review

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@legionus
Copy link
Contributor

Good catch! Thanks!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan, legionus, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4722af4 into openshift:master Aug 29, 2018
ccremer added a commit to vshn/openshift-ansible that referenced this pull request Nov 26, 2018
Resolves: AMZE-1223
Backport of upstream commit 60640ea, PR openshift#9821.
Log level debug is default in openshift, but Docker registry
defaults to info
ccremer added a commit to vshn/openshift-ansible that referenced this pull request Nov 26, 2018
Backport of upstream commit 60640ea, PR openshift#9821.
Log level debug is default in openshift, but Docker registry
defaults to info
hansmi pushed a commit to vshn/openshift-ansible that referenced this pull request Nov 26, 2018
Backport of upstream commit 60640ea, PR openshift#9821.
Log level debug is default in openshift, but Docker registry
defaults to info
corvus-ch pushed a commit to vshn/openshift-ansible that referenced this pull request Jan 24, 2019
Backport of upstream commit 60640ea, PR openshift#9821.
Log level debug is default in openshift, but Docker registry
defaults to info
mhutter pushed a commit to vshn/openshift-ansible that referenced this pull request Mar 18, 2019
Backport of upstream commit 60640ea, PR openshift#9821.
Log level debug is default in openshift, but Docker registry
defaults to info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants