New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OLM fixes #9949
OLM fixes #9949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
metadata: | ||
name: system:controller:operator-lifecycle-manager | ||
rules: | ||
- apiGroups: ["*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁
when: operator_lifecycle_manager_install | bool | ||
|
||
- include_tasks: remove.yaml | ||
when: operator_lifecycle_manager_remove | bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern I've seen is setting one variable for this (instead using "when: not operator_lifecycle_manager_install").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up with that in the future - I want to make sure everything is installing correctly first, if that's okay
1a1004f
to
25b04fe
Compare
/retest |
25b04fe
to
4cd3559
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-3.11 |
@ecordell: new pull request created: #9991 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixing the ansible install, the cluster role and updating the names in the catalog.