Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLM fixes #9949

Merged
merged 4 commits into from Sep 7, 2018
Merged

OLM fixes #9949

merged 4 commits into from Sep 7, 2018

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Sep 6, 2018

Fixing the ansible install, the cluster role and updating the names in the catalog.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2018
Copy link

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

metadata:
name: system:controller:operator-lifecycle-manager
rules:
- apiGroups: ["*"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

when: operator_lifecycle_manager_install | bool

- include_tasks: remove.yaml
when: operator_lifecycle_manager_remove | bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern I've seen is setting one variable for this (instead using "when: not operator_lifecycle_manager_install").

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up with that in the future - I want to make sure everything is installing correctly first, if that's okay

@ecordell
Copy link
Contributor Author

ecordell commented Sep 6, 2018

/retest

@jpeeler
Copy link
Contributor

jpeeler commented Sep 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b1af796 into openshift:master Sep 7, 2018
@ecordell ecordell deleted the olm-updates branch September 7, 2018 19:57
@ecordell
Copy link
Contributor Author

/cherrypick release-3.11

@openshift-cherrypick-robot

@ecordell: new pull request created: #9991

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants