Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1957584: Revert 'Bug 1896977: Enhance API host name validation' #210

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented May 24, 2021

This reverts commit 402c0fd.

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

@Miciah: This pull request references Bugzilla bug 1957584, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1957584: Revert "Bug 1896977: Enhance API host name validation"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 24, 2021
@Miciah Miciah force-pushed the BZ1957584-revert-enhance-API-host-name-validation branch from 5f5b66e to b8bb71d Compare May 24, 2021 14:14
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2021
@Miciah Miciah force-pushed the BZ1957584-revert-enhance-API-host-name-validation branch from b8bb71d to caa8773 Compare May 24, 2021 22:21
@Miciah
Copy link
Contributor Author

Miciah commented May 24, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

@Miciah: This pull request references Bugzilla bug 1957584, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @quarterpin

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 24, 2021
@openshift-ci openshift-ci bot requested a review from quarterpin May 24, 2021 22:21
@Miciah
Copy link
Contributor Author

Miciah commented May 24, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot

@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quarterpin
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2021

@quarterpin: This pull request references Bugzilla bug 1957584, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @quarterpin

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quarterpin
Copy link

/lgtm
/label qe-approved

Verified via pre-merge verification workflow, more reference related to the test can be found in:
https://bugzilla.redhat.com/show_bug.cgi?id=1957584#c15

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 26, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@Miciah
Copy link
Contributor Author

Miciah commented May 27, 2021

/test e2e-aws-serial

@Miciah
Copy link
Contributor Author

Miciah commented May 27, 2021

STEP 2: ENV "BUILD_LOGLEVEL"="0" "CLONEREFS_OPTIONS"="{\"src_root\":\"/go\",\"log\":\"/dev/null\",\"git_user_name\":\"ci-robot\",\"git_user_email\":\"ci-robot@openshift.io\",\"refs\":[{\"org\":\"openshift\",\"repo\":\"openshift-apiserver\",\"repo_link\":\"https://github.com/openshift/openshift-apiserver\",\"base_ref\":\"master\",\"base_sha\":\"aab4989f7957923355205378660f65a2bb0dd71d\",\"base_link\":\"https://github.com/openshift/openshift-apiserver/commit/aab4989f7957923355205378660f65a2bb0dd71d\",\"pulls\":[{\"number\":210,\"author\":\"Miciah\",\"sha\":\"caa8773bf4976b7311496e190b0d237675db12b7\",\"title\":\"Bug 1957584: Revert \\\"Bug 1896977: Enhance API host name validation\\\"\",\"link\":\"https://github.com/openshift/openshift-apiserver/pull/210\",\"commit_link\":\"https://github.com/openshift/openshift-apiserver/pull/210/commits/caa8773bf4976b7311496e190b0d237675db12b7\",\"author_link\":\"https://github.com/Miciah\"}]}],\"fail\":true}"
STEP 3: ADD ./clonerefs /clonerefs
STEP 4: RUN umask 0002 && /clonerefs && find /go/src -type d -not -perm -0775 | xargs --max-procs 10 --max-args 100 --no-run-if-empty chmod g+xw
time="2021-05-27T04:49:52Z" level=warning msg="Path \"/run/secrets/etc-pki-entitlement\" from \"/etc/containers/mounts.conf\" doesn't exist, skipping"
time="2021-05-27T04:49:52Z" level=warning msg="Path \"/run/secrets/redhat.repo\" from \"/etc/containers/mounts.conf\" doesn't exist, skipping"
{"component":"clonerefs","file":"prow/cmd/clonerefs/main.go:32","func":"main.main","level":"fatal","msg":"Could not resolve options: could not load config from JSON var CLONEREFS_OPTIONS: invalid character 'B' after object key:value pair","severity":"fatal","time":"2021-05-27T04:49:53Z"}

/retitle Bug 1957584: Revert 'Bug 1896977: Enhance API host name validation'
/test e2e-aws-serial

@openshift-ci openshift-ci bot changed the title Bug 1957584: Revert "Bug 1896977: Enhance API host name validation" Bug 1957584: Revert 'Bug 1896977: Enhance API host name validation' May 27, 2021
@Miciah
Copy link
Contributor Author

Miciah commented May 27, 2021

/test e2e-aws-serial

@deads2k
Copy link
Contributor

deads2k commented May 27, 2021

/approve

I'd like to see an update where the API and router validation match.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah, quarterpin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8be5c82 into openshift:master May 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2021

@Miciah: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1957584 has not been moved to the MODIFIED state.

In response to this:

Bug 1957584: Revert 'Bug 1896977: Enhance API host name validation'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Miciah: new pull request created: #211

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants