-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1978627: Validate secret name and configMap name #230
Bug 1978627: Validate secret name and configMap name #230
Conversation
@coreydaley: This pull request references Bugzilla bug 1978627, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @adambkaplan @sttts |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
/hold until https://github.com/openshift/openshift-apiserver/pull/230/files#r670400601 is answer. We cannot make validation stricter (without ratcheting validation) |
Please don't mix these into other commits, even that trivial things. Make another commit. |
/hold cancel |
@sttts ptal, comments have been addressed |
Validate the secret name and configMap name to provide a better user experience when creating a build config that contains buildVolumes
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, coreydaley, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@coreydaley: All pull requests linked via external trackers have merged: Bugzilla bug 1978627 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Validate the secret name and configMap name to provide a better user
experience when creating a build config that contains buildVolumes
Also, updating .gitignore to ignore _output directory that is not
cleaned up after running make verify