Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1978627: Validate secret name and configMap name #230

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Bug 1978627: Validate secret name and configMap name #230

merged 2 commits into from
Jul 15, 2021

Conversation

coreydaley
Copy link
Member

Validate the secret name and configMap name to provide a better user
experience when creating a build config that contains buildVolumes

Also, updating .gitignore to ignore _output directory that is not
cleaned up after running make verify

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@coreydaley: This pull request references Bugzilla bug 1978627, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 1978627: Validate secret name and configMap name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xiuwang July 14, 2021 16:33
@coreydaley
Copy link
Member Author

/assign @adambkaplan @sttts

@coreydaley
Copy link
Member Author

/retest

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@sttts
Copy link
Contributor

sttts commented Jul 15, 2021

/hold

until https://github.com/openshift/openshift-apiserver/pull/230/files#r670400601 is answer. We cannot make validation stricter (without ratcheting validation)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@sttts
Copy link
Contributor

sttts commented Jul 15, 2021

Also, updating .gitignore to ignore _output directory that is not
cleaned up after running make verify

Please don't mix these into other commits, even that trivial things. Make another commit.

@sttts
Copy link
Contributor

sttts commented Jul 15, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@coreydaley
Copy link
Member Author

@sttts ptal, comments have been addressed

Validate the secret name and configMap name to provide a better user
experience when creating a build config that contains buildVolumes
@sttts
Copy link
Contributor

sttts commented Jul 15, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@coreydaley
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit cd6a43a into openshift:master Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@coreydaley: All pull requests linked via external trackers have merged:

Bugzilla bug 1978627 has been moved to the MODIFIED state.

In response to this:

Bug 1978627: Validate secret name and configMap name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants