[release-4.9] Bug 2006791: prevent high frequency logging for aborting build generation from image change trigger based build requests using the deprecated build config spec last image change trigger ID field

[openshift-cherrypick-robot]

This is an automated cherry-pick of #246

/assign gabemontero

[openshift-ci]

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2004203 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

code 53: Bugzilla_api_key is not a valid parameter for the Bugzilla::Bug::create function.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2004203: no longer abort ICT induced builds because of spec last triggered image ID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/retitle [release-4.9] Bug 2006791: no longer abort ICT induced builds because of spec last triggered image ID

[openshift-ci]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2006791, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2006791: no longer abort ICT induced builds because of spec last triggered image ID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/retest

unrelated fails

[gabemontero]

/bugzilla refresh

[openshift-ci]

@gabemontero: This pull request references Bugzilla bug 2006791, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/bugzilla refresh

[openshift-ci]

@gabemontero: This pull request references Bugzilla bug 2006791, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/bugzilla refresh

[openshift-ci]

@gabemontero: This pull request references Bugzilla bug 2006791, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2004203 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2004203 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/assign @adambkaplan

for approval

/assign @coreydaley

for the new z stream process and getting the backport risk label

[gabemontero]

/lgtm

bot's pick looks OK

[adambkaplan]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/build/OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coreydaley]

/label backport-risk-assessed

[openshift-ci]

@coreydaley: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coreydaley]

/assign @sttts
This is for the backport risk

[adambkaplan]

/label backport-risk-assessed

[openshift-ci]

@adambkaplan: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sttts]

@adambkaplan @coreydaley please provide answers to the following:

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
   • verified
   • does not apply
2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.
   • verified
   • does not apply
3. For branches that are in the Maintenance lifecycle phase:
   • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
   • The bug is a security related bug
4. The severity field of the bug must be set to accurately reflect criticality.
   • verified
5. The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE. The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
   • verified

[coreydaley]

@adambkaplan @coreydaley please provide answers to the following:

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.

• verified
• does not apply

2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.

• verified
• does not apply

3. For branches that are in the Maintenance lifecycle phase:

• The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
• The bug is a security related bug

4. The severity field of the bug must be set to accurately reflect criticality.

• verified

5. The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE. The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.

• verified

[gabemontero]

@adambkaplan @coreydaley please provide answers to the following:

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.


* [ ]   verified

* [x]   does not apply


1. The bug has significant impact either through severity, reduction in supportability, or number of users affected.


* [x]   verified

* [ ]   does not apply


1. For branches that are in the Maintenance lifecycle phase:


* [x]   The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or

Small clarification @coreydaley @sttts - A workaround in fact has been proposed for bug. @jitendar-singh is attempting to verify it.

WRT criticality, the bug can result in repeated logging in openshift-apiserver logs.

* [ ]   The bug is a security related bug


1. The severity field of the bug must be set to accurately reflect criticality.


* [x]   verified


1. The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE. The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.


* [x]   verified

[adambkaplan]

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.

• verified
• does not apply

There is in fact a customer case associated with the parent BZ, I have applied the "FastFix" keyword as a result.

[gabemontero]

/retitle [release-4.9] Bug 2006791: prevent unnecessary logging for aborting build generation from image change trigger based build requests using the deprecated build config spec last image change trigger ID field

[adambkaplan]

There is in fact a customer case associated with the parent BZ, I have applied the "FastFix" keyword as a result.

I have since retraced the FastFix keyword, pending further updates. It appears that only a small percentage of BuildConfigs may be impacted on real clusters, in which case the published work-around is managable.

[adambkaplan]

/label backport-risk-assessed

• FastFix does not apply in this case due to published workaround
• Severity is ranked "high" due to its impact on the OpenShift and Kubernetes apiservers
• Fix applies to a branch that has full support (not a maintenance support version)
• Fix has been verified by QE in the main/master development branch
• Team has concluded the benefit of this change outweighs risks imposed.

[openshift-ci]

@adambkaplan: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

• FastFix does not apply in this case due to published workaround
• Severity is ranked "high" due to its impact on the OpenShift and Kubernetes apiservers
• Fix applies to a branch that has full support (not a maintenance support version)
• Fix has been verified by QE in the main/master development branch
• Team has concluded the benefit of this change outweighs risks imposed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/retitle [release-4.9] Bug 2006791: prevent high frequency logging for aborting build generation from image change trigger based build requests using the deprecated build config spec last image change trigger ID field

[openshift-ci]

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

• openshift/openshift-apiserver#247

The following pull requests linked via external trackers have not merged:

• openshift/openshift-controller-manager#203 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2006791 has not been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2006791: prevent high frequency logging for aborting build generation from image change trigger based build requests using the deprecated build config spec last image change trigger ID field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/cherrypick release-4.8

[openshift-cherrypick-robot]

@gabemontero: #247 failed to apply on top of branch "release-4.8":

Applying: no longer abort ICT induced builds because of spec last triggered image ID
Using index info to reconstruct a base tree...
M	pkg/build/apiserver/buildgenerator/generator.go
M	pkg/build/apiserver/buildgenerator/generator_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/build/apiserver/buildgenerator/generator_test.go
CONFLICT (content): Merge conflict in pkg/build/apiserver/buildgenerator/generator_test.go
Auto-merging pkg/build/apiserver/buildgenerator/generator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 no longer abort ICT induced builds because of spec last triggered image ID
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.