Bug 2018442: Image policy should mutate DeploymentConfigs

[dmage]

This is a cherry-pick of #250 to address the bug 2018442.

Impact: Resolution of image stream names in deployment configs does not work because the image policy plugin does not know about them.

Cause: The problem exists since the beginning, but it wasn't visible as the image policy plugin used to resolve image streams names in all pods. Once we've fixed the bug 1925180, the plugin doesn't update controlled objects anymore, i.e. it doesn't update pods that are created for the deployment config.

Resolution: Update the admission plugin so that is aware of deployment configs.

[openshift-ci]

@dmage: This pull request references Bugzilla bug 2018442, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2000216 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2000216 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 2018442: Image policy should mutate DeploymentConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dmage]

/assign @sttts

[soltysh]

/lgtm

[sttts]

/approve

[sttts]

@dmage can you provide the following:

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
   • verified
   • does not apply
2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.
   • verified
   • does not apply
3. For branches that are in the Maintenance lifecycle phase:
   • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
   • The bug is a security related bug
   • Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
4. The severity field of the bug must be set to accurately reflect criticality.
   • verified
5. The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
   • verified

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dmage: This pull request references Bugzilla bug 2018442, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2000216 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2000216 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
• bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 2018442: Image policy should mutate DeploymentConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dmage: An error was encountered querying GitHub for users with public email (xiuwang@redhat.com) for bug 2018442 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2018442: Image policy should mutate DeploymentConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dmage]

1. If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.

   • verified
   • does not apply

2. The bug has significant impact either through severity, reduction in supportability, or number of users affected.

   • verified
   • does not apply

3. For branches that are in the Maintenance lifecycle phase:

   • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
   • The bug is a security related bug
   • Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)

4. The severity field of the bug must be set to accurately reflect criticality.

   • verified

5. The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.

   • verified

[wangke19]

/label cherry-pick-approved

[openshift-ci]

@dmage: Some pull requests linked via external trackers have merged:

• openshift/apiserver-library-go#70
• openshift/kubernetes#1033
• openshift/openshift-apiserver#255

The following pull requests linked via external trackers have not merged:

• openshift/origin#26567 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2018442 has not been moved to the MODIFIED state.

In response to this:

Bug 2018442: Image policy should mutate DeploymentConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.