Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2053218: Fix importing images that have dots in their namespace #281

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Bug 2053218: Fix importing images that have dots in their namespace #281

merged 1 commit into from
Feb 14, 2022

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Feb 11, 2022

Backport of #279.

This PR bumps library-go to get a new registryclient that can correctly
handle image references like

registry.example.com/namespace.with.dot/foo

@dmage
Fix importing images that have dots in their namespace
a026d37 
This change bumps library-go to get a new registryclient that can
correctly handle image references like

    registry.example.com/namespace.with.dot/foo
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Feb 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2022

@dmage: This pull request references Bugzilla bug 2053218, which is invalid:

  • expected dependent Bugzilla bug 2049234 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2053218: Fix importing images that have dots in their namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 11, 2022
@dmage dmage mentioned this pull request Feb 11, 2022
Merged
@dmage
Copy link
Contributor Author

dmage commented Feb 11, 2022

/retest

@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 11, 2022
@bparees
Copy link
Contributor

bparees commented Feb 11, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2022

@bparees: This pull request references Bugzilla bug 2053218, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2049234 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2049234 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xiuwang February 11, 2022 16:05
@bparees bparees added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 11, 2022
@dmage
Copy link
Contributor Author

dmage commented Feb 11, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 11, 2022
@dmage
Copy link
Contributor Author

dmage commented Feb 11, 2022

/assign @tkashem

@dmage
Copy link
Contributor Author

dmage commented Feb 11, 2022

/retest

@xiuwang
Copy link

xiuwang commented Feb 12, 2022

/label qe-approved
/label cherry-pick-approved
https://bugzilla.redhat.com/show_bug.cgi?id=2053218#c1

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2022

@xiuwang: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label qe-approved
/label cherry-pick-approved
https://bugzilla.redhat.com/show_bug.cgi?id=2053218#c1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiuwang
Copy link

xiuwang commented Feb 12, 2022

/retest

@openshift-ci openshift-ci bot mentioned this pull request Feb 14, 2022
Merged
@xiuwang
Copy link

xiuwang commented Feb 14, 2022

/retest

@gangwgr
Copy link

gangwgr commented Feb 14, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 14, 2022
@tkashem
Copy link
Contributor

tkashem commented Feb 14, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

@dmage: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6b16f7f into openshift:release-4.10 Feb 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 2053218 has been moved to the MODIFIED state.

In response to this:

Bug 2053218: Fix importing images that have dots in their namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dmage @bparees @xiuwang @gangwgr @tkashem @openshift-bot @openshift-merge-robot