Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make route validation operate on v1 types. #312

Merged
merged 1 commit into from Sep 27, 2022
Merged

Make route validation operate on v1 types. #312

merged 1 commit into from Sep 27, 2022

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Sep 22, 2022 •
edited

To allow for reuse on variants serving routes via CRD, convert from
internal to v1 types and validate those. The v1 validation logic will
then be able to move to a library, where it can be shared without any
dependencies on openshift-apiserver.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@benluddy benluddy force-pushed the route-validation-v1 branch 2 times, most recently from 3a28992 to 848774e Compare September 26, 2022 22:04
@benluddy benluddy changed the title wip: perform route validation on external v1 api Make route validation operate on v1 types. Sep 26, 2022
@benluddy benluddy marked this pull request as ready for review September 26, 2022 22:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022
@benluddy
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022
@benluddy
Make route validation operate on v1 types.
473697a 
To allow for reuse on variants serving routes via CRD, convert from
internal to v1 types and validate those. The v1 validation logic will
then be able to move to a library, where it can be shared without any
dependencies on openshift-apiserver.
@deads2k
Copy link
Contributor

deads2k commented Sep 27, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ae6616f and 2 for PR HEAD 473697a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1a80d65 and 1 for PR HEAD 473697a in total

@deads2k
Copy link
Contributor

deads2k commented Sep 27, 2022

/override ci/prow/e2e-aws-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k merged commit b78bba4 into openshift:master Sep 27, 2022
@benluddy benluddy mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@knobunc knobunc Awaiting requested review from knobunc

@pweil- pweil- Awaiting requested review from pweil-

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benluddy @deads2k @openshift-ci-robot