Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use route/v1 types for route warnings. #317

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

benluddy
Copy link
Contributor

Follow-up to #312, giving warnings the same treatment for the same reasons.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@benluddy
Copy link
Contributor Author

/test e2e-aws
/test verify

@benluddy
Copy link
Contributor Author

/test verify

Still working to resolve the issue with openapi-gen nondeterminism.

@benluddy
Copy link
Contributor Author

/retest-required

@deads2k
Copy link
Contributor

deads2k commented Oct 3, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3c720ab and 2 for PR HEAD fdfbac2 in total

@benluddy
Copy link
Contributor Author

benluddy commented Oct 4, 2022

/test e2e-aws-serial

1 similar comment
@benluddy
Copy link
Contributor Author

benluddy commented Oct 5, 2022

/test e2e-aws-serial

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@benluddy
Copy link
Contributor Author

benluddy commented Oct 5, 2022

/test verify

1 similar comment
@benluddy
Copy link
Contributor Author

benluddy commented Oct 5, 2022

/test verify

@deads2k
Copy link
Contributor

deads2k commented Oct 6, 2022

installed and routes ran ok

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-upgrade

@deads2k
Copy link
Contributor

deads2k commented Oct 6, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws, ci/prow/e2e-aws-serial, ci/prow/e2e-aws-upgrade

In response to this:

installed and routes ran ok

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@benluddy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-cmd eae28d1 link false /test e2e-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7832216 into openshift:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants