Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource group and resource names in appinsights.md #2108

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 27, 2019

NONE

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2019
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #2108 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2108   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files         332      332           
  Lines       26650    26650           
=======================================
  Hits        11900    11900           
  Misses      14085    14085           
  Partials      665      665

@pnasrat
Copy link

pnasrat commented Nov 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: m1kola, pnasrat
To complete the pull request process, please assign asalkeld
You can assign the PR to them by writing /assign @asalkeld in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jim-minter jim-minter merged commit 8c6e839 into openshift:master Nov 27, 2019
@openshift-ci-robot
Copy link

@m1kola: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
e2e-create-20191027-private 0187570 link /test e2e-create-20191027-private
upgrade-v7.1 0187570 link /test upgrade-v7.1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1kola m1kola deleted the patch-2 branch September 29, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants