Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/modify code referring to v13 [WIP] #2179

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Remove/modify code referring to v13 [WIP] #2179

merged 1 commit into from
Jan 15, 2020

Conversation

nilsanderselde
Copy link
Contributor

@nilsanderselde nilsanderselde commented Jan 13, 2020 •
edited
Loading 

Since version 13 was skipped, remove it from repo.

Mostly file deletions, with a few line removals. Besides that, there is a single check which has been incremented from 13 to 14.

@openshift-ci-robot openshift-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 13, 2020
@nilsanderselde
Copy link
Contributor Author

/assign @mjudeikis

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #2179 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage    43.4%   43.38%   -0.02%     
==========================================
  Files         319      319              
  Lines       25198    25209      +11     
==========================================
  Hits        10936    10936              
- Misses      13637    13648      +11     
  Partials      625      625

@nilsanderselde
Copy link
Contributor Author

/retest

@nilsanderselde
Copy link
Contributor Author

/test e2e-create-20191027-private

@troy0820
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@mjudeikis
Copy link
Contributor

/hold
remove hold when release repo removals merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020
@mjudeikis
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@pnasrat
Copy link

pnasrat commented Jan 15, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, nilsanderselde, pnasrat, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilsanderselde nilsanderselde mentioned this pull request Jan 15, 2020
Merged
@nilsanderselde
Copy link
Contributor Author

/unhold

openshift/release#6715 has been merged

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit e4c9bd0 into openshift:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gburges gburges Awaiting requested review from gburges

@m1kola m1kola Awaiting requested review from m1kola

Assignees

@pnasrat pnasrat

@mjudeikis mjudeikis

@troy0820 troy0820

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nilsanderselde @troy0820 @mjudeikis @pnasrat @openshift-ci-robot @openshift-merge-robot