add master-data pvc for etcd #65
Conversation
|
I would suggest switching to a statefulset.
…On Mon, Jul 9, 2018, 15:55 Mangirdas Judeikis ***@***.***> wrote:
cc: @pweil- <https://github.com/pweil-> @Kargakis
<https://github.com/kargakis> @jim-minter <https://github.com/jim-minter>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuFf_zb0FzdbBvEcWTZRKAVUNYJu-pWks5uE2DdgaJpZM4VHwCm>
.
|
|
@Kargakis for etcd itself? |
|
POC for etcd operator, so we might, can this and move straight to operators. Need to discuss. |
|
Close in favor of #67? |
|
we need to be testing real upgrades, this would let us do that while we work on the operator implementation. I'm in favor of closing if we can get the operator in shape quickly (like this week) but I don't want to hold up upgrade testing all next week if it's going to take some time. @mjudeikis wdyt about the ETA for remaining work on #67? |
|
I would say merge and operator will be built ontop? This will enable people to do testing with what we have now. I think a working example for #67 is possible for tomorrow evening. |
|
If we can't have the operator in time then I'd still vote for switching etcd to a statefulset. |
pkg/config/generate.go
Outdated
| @@ -72,6 +72,7 @@ func Generate(cs *acsapi.ContainerService, c *Config) (err error) { | |||
| c.Version = versionLatest | |||
| c.ImageConfigFormat = "openshift/origin-${component}:${version}" | |||
| c.TunnelHostname = strings.Replace(cs.Properties.OrchestratorProfile.OpenShiftConfig.PublicHostname, "openshift", "openshift-tunnel", 1) | |||
| c.EtcdPVCStorageClassName = "managed-premium" | |||
There was a problem hiding this comment.
Why not set this directly in the PVC? It's always going to be managed-premium or whatever gives etcd an SSD.
Probably worth holding out then. |
|
@Kargakis statefulset would be nice but when I tried to implement it I got stuck with kubernetes/kubernetes#52653 - kubectl rollout status statefulset hangs forever if a rollout is not actually happening |
|
@mjudeikis pushed some commits to clean up; merging |
|
kubernetes/kubernetes#62943 needs to be cherrypicked in origin#master and origin#release-3.10 |
Hrm, I just realized cherrypicking this back to origin does not help in our case since the issue is still present in the underlying aks cluster :( |
This reverts commit b3dde3a.
Add pvc for master-data /etcd container
We could do without storageclass name but left it as we still dont know how final HCP will look like.