[release-4.3] Bug 1831888: v1 StatefulSets do not trigger on image changeS

[openshift-cherrypick-robot]

This is an automated cherry-pick of #99

/assign smarterclayton

[openshift-ci-robot]

@openshift-cherrypick-robot: Bugzilla bug 1831243 has been cloned as Bugzilla bug 1831888. Retitling PR to link against new bug.
/retitle [release-4.3] Bug 1831888: v1 StatefulSets do not trigger on image changes

In response to this:

[release-4.3] Bug 1831243: v1 StatefulSets do not trigger on image changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smarterclayton]

/hold

may not be necessary for backport, will start with 4.4

[stevekuznetsov]

/retitle [release-4.3] Bug 1831888: v1 StatefulSets do not trigger on image changeS

[adambkaplan]

/bugzilla refresh

/retest

[openshift-ci-robot]

@adambkaplan: This pull request references Bugzilla bug 1831888, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.3.z) matches configured target release for branch (4.3.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1831245 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1831245 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
• bug has dependents

In response to this:

/bugzilla refresh

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

/retest

[adambkaplan]

/lgtm

@smarterclayton do we still need this in 4.3?

[adambkaplan]

/retest

[openshift-ci-robot]

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-builds	eed6a42	link	/test e2e-gcp-builds
ci/prow/e2e-aws	eed6a42	link	/test e2e-aws
ci/prow/e2e-gcp	eed6a42	link	/test e2e-gcp
ci/prow/e2e-aws-upgrade	eed6a42	link	/test e2e-aws-upgrade
ci/prow/unit	eed6a42	link	/test unit
ci/prow/verify	eed6a42	link	/test verify
ci/prow/images	eed6a42	link	/test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[adambkaplan]

/lgtm cancel

This includes k8s API changes that were introduced in 4.4.

@smarterclayton do we in fact need to backport this?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

If we are sure this won't fail in 4.3, no, we don't need to backport.

…

On Fri, May 29, 2020 at 7:50 AM OpenShift CI Robot ***@***.***> wrote: [APPROVALNOTIFIER] This PR is *NOT APPROVED* This pull-request has been approved by: *openshift-cherrypick-robot <#101#>* To complete the pull request process <https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>, please assign *adambkaplan* You can assign the PR to them by writing /assign @adambkaplan in a comment when ready. The full list of commands accepted by this bot can be found here <https://go.k8s.io/bot-commands?repo=openshift%2Fopenshift-controller-manager> . Needs approval from an approver in each of these files: - *OWNERS <https://github.com/openshift/openshift-controller-manager/blob/release-4.3/OWNERS>* Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI37J56Y54ERZPMOZY7Z2LRT6OQLANCNFSM4MZ4EQMQ> .

[adambkaplan]

4.3 is on k8s 1.16, which does have the v1/StatefulSet API. I can manually backport.

[adambkaplan]

/close

Replaced by #116

[openshift-ci-robot]

@adambkaplan: Closed this PR.

In response to this:

/close

Replaced by #116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1831888. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1831888: v1 StatefulSets do not trigger on image changeS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.